[EMCAL] Modernize EMCal code#15600
Draft
mhemmer-cern wants to merge 3 commits into
Draft
Conversation
- Moderinze EMCal code: EMCALBase/Geometry and ClusterFactory Classes and DataFormatsEMCAL classes, removing c-style arrays - Fixing clang-tidy warnings and errors that would appear when using the O2Physics clang-tidy settings - Switching from gsl::span to std::span to use official stl container [EMCAL] update
Please consider the following formatting changes to AliceO2Group#15600
Contributor
Author
|
This might also be a good time to think which classes we really need to write into ROOT files. For example, I do not think that the ClusterFactory should be written to ROOT files, but maybe I am overlooking something. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modernize EMCal code: EMCALBase/Geometry and ClusterFactory Classes and DataFormatsEMCAL classes:
In Cell.cxx add new function
unpackV0to unpack/decode the bitfields. Previously we just reinterpret_cast<const DecodingV0::CellDataPacked*> some const char* variable which violate type safety. Now it uses memcpy to safely copy the data from the buffer into the newDecodingV0::CellDataPackedobject.Fix return type for
getCoreRadius(was bool should be float) and argument type forsetUseWeightExotic(float useWeightExoticwhich should besetUseWeightExotic(bool useWeightExotic).Removes streaming of spans from ROOT IO in ClusterFactory, since they are non owing spans.
Fixed some argument name differences between the definition and implementation of some functions.